Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtl872x] WPA3 and hidden SSID support #2673

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Conversation

avtolstoy
Copy link
Member

Description

Support for WPA3 and hidden SSIDs (note that correct channel plan e.g. US needs to be set for 5GHz hidden SSID support to work, otherwise 5GHz scans are passive).

Steps to Test

  1. Configure WPA3 credentials over Serial in listening mode and attempt to connect (need to select '6' for WPA3, won't be prompted as an option)
  2. Configure credentials with hidden SSID with a test app and attempt to connect
    WiFiCredentials cred;
    cred.setSsid("Particle");
    cred.setPassword("Particle");
    cred.setCipher(WLAN_CIPHER_AES);
    cred.setSecurity(spark::SecurityType::WPA2);
    cred.setHidden(true);
    WiFi.setCredentials(cred);

Problems

CLI uses hardcoded serial prompts as triggers (https://github.com/particle-iot/particle-cli/blob/master/src/cmd/serial.js#L1003), adding WPA3 option there breaks older CLI.

Should we migrate to using USB requests instead?


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy
Copy link
Member Author

Note for future reference: there is still a problem with Realtek SDK and WPA version, we'll look into that before 5.5.0 final.

@avtolstoy avtolstoy merged commit eaa23ff into develop Aug 15, 2023
1 check was pending
@avtolstoy avtolstoy deleted the feature/rtl872x-wpa3-support branch August 15, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants